HEAD requests can return a body #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd be happy to take a pull request :) |
|
Happy to work on one, just wanted to open #190 as well to hear your overall input :) |
"The HEAD method is identical to GET except that the server MUST NOT return a message-body in the response." http://www.w3.org/Protocols/rfc2616/rfc2616-sec9.html#sec9.4 Signed-off-by: Stephen Celis <stephen@stephencelis.com>
|
Simple enough fix. |
|
This looks right to me, thank you. I don't see why anyone wouldn't want this by default. Will keep open for a bit for comments before merging. |
|
I forgot to ask you to update CHANGELOG. I'll merge this then. Thank you. |
dblock
added a commit
that referenced
this pull request
Jul 9, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, Grape doesn't adhere to HTTP/1.1:
—http://www.w3.org/Protocols/rfc2616/rfc2616-sec9.html#sec9.4
(A simple
curl -X HEADwill show the body for a HEAD endpoint.)